frzysk/42_minishell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

check TODO

Browse source
This commit is contained in:
mcolonna 2024-04-26 12:33:38 +02:00
parent d90fc62be5
commit 149bafef88
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
include/include.h
View file

@ -6,7 +6,7 @@
/* By: mcolonna <marvin@42.fr> +#+ +:+ +#+ */ /* By: mcolonna <marvin@42.fr> +#+ +:+ +#+ */
/* +#+#+#+#+#+ +#+ */ /* +#+#+#+#+#+ +#+ */
/* Created: 2024/04/23 14:15:12 by mcolonna #+# #+# */ /* Created: 2024/04/23 14:15:12 by mcolonna #+# #+# */
/* Updated: 2024/04/26 12:27:17 by mcolonna ### ########.fr */ /* Updated: 2024/04/26 12:33:20 by mcolonna ### ########.fr */
/* */ /* */
/* ************************************************************************** */ /* ************************************************************************** */
@ -38,7 +38,7 @@ typedef struct s_call
{ {
const char *program; // path of the program to call. const char *program; // path of the program to call.
int argc; // number of arguments given int argc; // number of arguments given
char *const *argv; // arguments given char *const *argv; // arguments given (ended by NULL)
// (argc and argv must include the program name) // (argc and argv must include the program name)
} t_call; } t_call;
@ -46,7 +46,7 @@ typedef struct s_call
typedef struct s_command typedef struct s_command
{ {
bool error; // true if an error occured in interpret_command(). bool error; // true if an error occured in interpret_command().
const t_call *calls; // all calls to programs. const t_call *calls; // all calls to programs (ended by .program == NULL)
int input_fd; // fd to use with '<' redirection (0 by default) int input_fd; // fd to use with '<' redirection (0 by default)
int output_fd; // fd to use with '>' redirection (1 by default) int output_fd; // fd to use with '>' redirection (1 by default)
} t_command; } t_command;

3
src/exec_command.c
View file

@ -6,7 +6,7 @@
/* By: jschaft <cecile.schaft@orange.fr> +#+ +:+ +#+ */ /* By: jschaft <cecile.schaft@orange.fr> +#+ +:+ +#+ */
/* +#+#+#+#+#+ +#+ */ /* +#+#+#+#+#+ +#+ */
/* Created: 2024/04/24 13:48:00 by jschaft #+# #+# */ /* Created: 2024/04/24 13:48:00 by jschaft #+# #+# */
/* Updated: 2024/04/26 12:26:56 by mcolonna ### ########.fr */ /* Updated: 2024/04/26 12:31:49 by mcolonna ### ########.fr */
/* */ /* */
/* ************************************************************************** */ /* ************************************************************************** */
@ -26,7 +26,6 @@ static void free_tab(char **tab)
free(tab); free(tab);
} }
// TODO works with only one call (no pipe).
// TODO is t_call.argv ended by NULL? // TODO is t_call.argv ended by NULL?
static void fork_exec(const char *path, t_call call, const int inout[2], static void fork_exec(const char *path, t_call call, const int inout[2],
char *const envp[]) char *const envp[])