From 0e38c9cdd3c7b60d1f52a76045ad7cbf64e6a5da Mon Sep 17 00:00:00 2001 From: mcolonna Date: Wed, 2 Apr 2025 18:38:09 +0200 Subject: [PATCH] dev: rewrite TODOs --- Makefile | 2 +- srcs/docker-compose.yml | 4 ++-- srcs/requirements/nginx/Dockerfile | 4 ++-- srcs/requirements/nginx/conf/nginx.conf | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 4f560ac..2287ed3 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -# TODO data is supposed to be in $HOME/data/ +# TODO(vm) data is supposed to be in $HOME/data/ DOCKER=docker SRC_COMPOSE=srcs/ diff --git a/srcs/docker-compose.yml b/srcs/docker-compose.yml index 5732329..7d1b4a9 100644 --- a/srcs/docker-compose.yml +++ b/srcs/docker-compose.yml @@ -2,11 +2,11 @@ name: my-awesome-compose services: nginx: - # TODO no latest?? + # TODO(any)(latest) no latest?? build: ./requirements/nginx/ ports: - 4433:443 - # domainname: mcolonna.42.fr # TODO useful? # TODO no copy + # domainname: mcolonna.42.fr # TODO(vm) useful? # TODO(any)(nocopy) ### services ### # image: diff --git a/srcs/requirements/nginx/Dockerfile b/srcs/requirements/nginx/Dockerfile index 638280f..ac5fb93 100644 --- a/srcs/requirements/nginx/Dockerfile +++ b/srcs/requirements/nginx/Dockerfile @@ -1,4 +1,4 @@ -# TODO no latest +# TODO(any)(latest) FROM alpine:latest EXPOSE 443 @@ -9,7 +9,7 @@ RUN apk add curl RUN apk fix # install nginx -# TODO installed automatically? +# TODO(any) installed automatically? #RUN apk add openssl curl ca-certificates RUN printf "%s%s%s%s\n" \ "@nginx " \ diff --git a/srcs/requirements/nginx/conf/nginx.conf b/srcs/requirements/nginx/conf/nginx.conf index 2faf0dc..a9592ee 100644 --- a/srcs/requirements/nginx/conf/nginx.conf +++ b/srcs/requirements/nginx/conf/nginx.conf @@ -1,4 +1,4 @@ -# TODO clean comments? +# TODO(any) clean comments? user nginx; worker_processes auto; @@ -31,11 +31,11 @@ http { server { listen 443 ssl; - server_name mcolonna.42.fr; # TODO from env var? + server_name mcolonna.42.fr; # TODO(any)(nocopy) ssl_certificate mcolonna.42.fr.crt; - ssl_certificate_key mcolonna.42.fr.key; # TODO secret? # TODO in .cert? + ssl_certificate_key mcolonna.42.fr.key; # TODO(any)(secret) secret? # TODO(any)(nocopy) ssl_protocols TLSv1.3; - # TODO ssl_ciphers + # TODO ssl_ciphers(any) #access_log /var/log/nginx/host.access.log main;