[mod] activate pyright checks (in CI)

We have been using a static type checker (pyright) for a long time, but its
check was not yet a prerequisite for passing the quality gate.  It was checked
in the CI, but the error messages were only logged.

As is always the case in life, with checks that you have to do but which have no
consequences; you neglect them :-)

We didn't activate the checks back then because we (even today) have too much
monkey patching in our code (not only in the engines, httpx and others objects
are also affected).

We want to replace monkey patching with clear interfaces for a long time, the
basis for this is increased typing and we can only achieve this if we make type
checking an integral part of the quality gate.

  This PR activates the type check; in order to pass the check, a few typings
  were corrected in the code, but most type inconsistencies were deactivated via
  inline comments.

This was particularly necessary in places where the code uses properties that
stick to the objects (monkey patching).  The sticking of properties only happens
in a few places, but the access to these properties extends over the entire
code, which is why there are many `# type: ignore` markers in the code ... which
we will hopefully be able to remove again successively in the future.

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>

searx/search/checker/background.py

@@ -81,7 +81,7 @@ def get_result() -> CheckerResult:
     if client is None:
         # without Redis, the checker is disabled
         return {'status': 'disabled'}
-    serialized_result: Optional[bytes] = client.get(REDIS_RESULT_KEY)
+    serialized_result: Optional[bytes] = client.get(REDIS_RESULT_KEY)  # type: ignore
     if serialized_result is None:
         # the Redis key does not exist
         return {'status': 'unknown'}

searx/search/checker/impl.py

@@ -263,7 +263,7 @@ class ResultContainerTests:  # pylint: disable=missing-class-docstring
     def check_basic(self):
         if len(self.result_container.unresponsive_engines) > 0:
             for message in self.result_container.unresponsive_engines:
-                self._record_error(message[1] + ' ' + (message[2] or ''))
+                self._record_error(message.error_type + ' ' + (str(message.suspended) if message.suspended else ''))
             self.stop_test = True
             return
 

searx/search/checker/scheduler.py

@@ -11,10 +11,10 @@ This scheduler is not generic on purpose: if more feature are required, a dedica
 (= a better scheduler should not use the web workers)
 """
 
+from typing import Callable
 import logging
 import time
 from pathlib import Path
-from typing import Callable
 
 from searx.redisdb import client as get_redis_client
 from searx.redislib import lua_script_storage