Faroo's unit test

searx/engines/faroo.py

@@ -37,7 +37,7 @@ search_category = {'general': 'web',
 
 # do search-request
 def request(query, params):
-    offset = (params['pageno']-1) * number_of_results + 1
+    offset = (params['pageno'] - 1) * number_of_results + 1
     categorie = search_category.get(params['category'], 'web')
 
     if params['language'] == 'all':
@@ -45,11 +45,11 @@ def request(query, params):
     else:
         language = params['language'].split('_')[0]
 
-    # skip, if language is not supported
+    # if language is not supported, put it in english
     if language != 'en' and\
        language != 'de' and\
        language != 'zh':
-        return params
+        language = 'en'
 
     params['url'] = search_url.format(offset=offset,
                                       number_of_results=number_of_results,
@@ -69,12 +69,10 @@ def response(resp):
     # HTTP-Code 401: api-key is not valide
     if resp.status_code == 401:
         raise Exception("API key is not valide")
-        return []
 
     # HTTP-Code 429: rate limit exceeded
     if resp.status_code == 429:
         raise Exception("rate limit has been exceeded!")
-        return []
 
     results = []
 

searx/tests/engines/test_faroo.py

@@ -0,0 +1,116 @@
+# -*- coding: utf-8 -*-
+from collections import defaultdict
+import mock
+from searx.engines import faroo
+from searx.testing import SearxTestCase
+
+
+class TestFarooEngine(SearxTestCase):
+
+    def test_request(self):
+        query = 'test_query'
+        dicto = defaultdict(dict)
+        dicto['pageno'] = 1
+        dicto['language'] = 'fr_FR'
+        dicto['category'] = 'general'
+        params = faroo.request(query, dicto)
+        self.assertIn('url', params)
+        self.assertIn(query, params['url'])
+        self.assertIn('faroo.com', params['url'])
+        self.assertIn('en', params['url'])
+        self.assertIn('web', params['url'])
+
+        dicto['language'] = 'all'
+        params = faroo.request(query, dicto)
+        self.assertIn('en', params['url'])
+
+        dicto['language'] = 'de_DE'
+        params = faroo.request(query, dicto)
+        self.assertIn('de', params['url'])
+
+    def test_response(self):
+        self.assertRaises(AttributeError, faroo.response, None)
+        self.assertRaises(AttributeError, faroo.response, [])
+        self.assertRaises(AttributeError, faroo.response, '')
+        self.assertRaises(AttributeError, faroo.response, '[]')
+
+        response = mock.Mock(text='{}')
+        self.assertEqual(faroo.response(response), [])
+
+        response = mock.Mock(text='{"data": []}')
+        self.assertEqual(faroo.response(response), [])
+
+        response = mock.Mock(text='{"data": []}', status_code=401)
+        self.assertRaises(Exception, faroo.response, response)
+
+        response = mock.Mock(text='{"data": []}', status_code=429)
+        self.assertRaises(Exception, faroo.response, response)
+
+        json = """
+        {
+          "results": [
+            {
+              "title": "This is the title",
+              "kwic": "This is the content",
+              "content": "",
+              "url": "http://this.is.the.url/",
+              "iurl": "",
+              "domain": "css3test.com",
+              "author": "Jim Dalrymple",
+              "news": true,
+              "votes": "10",
+              "date": 1360622563000,
+              "related": []
+            },
+            {
+              "title": "This is the title2",
+              "kwic": "This is the content2",
+              "content": "",
+              "url": "http://this.is.the.url2/",
+              "iurl": "",
+              "domain": "css3test.com",
+              "author": "Jim Dalrymple",
+              "news": false,
+              "votes": "10",
+              "related": []
+            },
+            {
+              "title": "This is the title3",
+              "kwic": "This is the content3",
+              "content": "",
+              "url": "http://this.is.the.url3/",
+              "iurl": "http://upload.wikimedia.org/optimized.jpg",
+              "domain": "css3test.com",
+              "author": "Jim Dalrymple",
+              "news": false,
+              "votes": "10",
+              "related": []
+            }
+          ],
+          "query": "test",
+          "suggestions": [],
+          "count": 100,
+          "start": 1,
+          "length": 10,
+          "time": "15"
+        }
+        """
+        response = mock.Mock(text=json)
+        results = faroo.response(response)
+        self.assertEqual(type(results), list)
+        self.assertEqual(len(results), 4)
+        self.assertEqual(results[0]['title'], 'This is the title')
+        self.assertEqual(results[0]['url'], 'http://this.is.the.url/')
+        self.assertEqual(results[0]['content'], 'This is the content')
+        self.assertEqual(results[1]['title'], 'This is the title2')
+        self.assertEqual(results[1]['url'], 'http://this.is.the.url2/')
+        self.assertEqual(results[1]['content'], 'This is the content2')
+        self.assertEqual(results[3]['img_src'], 'http://upload.wikimedia.org/optimized.jpg')
+
+        json = """
+        {}
+        """
+        response = mock.Mock(text=json)
+        results = faroo.response(response)
+        self.assertEqual(type(results), list)
+        self.assertEqual(len(results), 0)

searx/tests/test_engines.py

@@ -9,6 +9,7 @@ from searx.tests.engines.test_deviantart import *  # noqa
 from searx.tests.engines.test_digg import *  # noqa
 from searx.tests.engines.test_duckduckgo import *  # noqa
 from searx.tests.engines.test_dummy import *  # noqa
+from searx.tests.engines.test_faroo import *  # noqa
 from searx.tests.engines.test_flickr import *  # noqa
 from searx.tests.engines.test_flickr_noapi import *  # noqa
 from searx.tests.engines.test_github import *  # noqa